Cnwankwo/together mode ut #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled together mode signaling divs to be tabable
….com/Azure/communication-ui-library into cnwankwo/together_mode_bugbash_fixes
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-akqtlirurs.chromatic.com/ |
cn0151
changed the base branch from
main
to
cnwankwo/together_mode_bugbash_fixes
cn0151
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft and
jpeng-ms
and removed request for
a team
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fubxvgnxzd.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gcingqeskj.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gnjzkhtcsz.chromatic.com/ |
cn0151
added
the
does not need changelog
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oscgqnbqia.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nbonmechmx.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-skmzbucyow.chromatic.com/ |
…ommunication-ui-library into cnwankwo/togetherMode_UT
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qvvxliawqh.chromatic.com/ |
edwardlee-msft
approved these changes
Feb 7, 2025
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fqeyvxkefg.chromatic.com/ |
…ommunication-ui-library into cnwankwo/togetherMode_UT
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ibhcixkqhw.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Unit test for together mode
Why
Needed as part of together mode integration
How Tested
locally
Process & policy checklist
Is this a breaking change?